myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Freedman (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (MYFACES-3042) CCE: when running in portlet: Remove Servlet dependencies in FaceletViewDeclarationLanguage.java
Date Tue, 15 Feb 2011 17:09:01 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-3042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12994882#comment-12994882
] 

Michael Freedman commented on MYFACES-3042:
-------------------------------------------

I have attached a potential patch -- Apologies for not just making the changes but (1) this
change breaks an automated test that is part of the build as it seems the test environment
doesn't provide its own stub impl of the new JSF 2.0 ExternalContext methods that these changes
rely on -- and I have no clue how to address those and (2) the various paperwork Oracle made
me sign to allow me to participate in Apache only allows me to submit work related to the
Portlet Bridge project -- MyFaces work has to be submitted by those from Oracle signed up
to do that.

> CCE: when running in portlet: Remove Servlet dependencies in FaceletViewDeclarationLanguage.java
> ------------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-3042
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3042
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: Portlet_Support
>    Affects Versions: 2.0.5-SNAPSHOT
>            Reporter: Michael Freedman
>         Attachments: jira-myfaces-3042.patch
>
>
> In FaceletViewDeclarationLanguage.java: createResponseWriter(), getResponseEncoding(),
handleFaceletNotFound(), and sendSourceNotFound() each cast to Servlet object.  This causes
ClassCastExceptions when run in a portlet environment.  Each of these calls/casts can be removed
and ExternalContext APIs can be used instead to get/set the needed information from the request
or response object.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message