myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jan-Kees van Andel (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (MYFACES-3049) Bean Validation doesn't work with Glassfish el-impl-2.2
Date Mon, 21 Feb 2011 10:59:38 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12997347#comment-12997347
] 

Jan-Kees van Andel commented on MYFACES-3049:
---------------------------------------------

Not sure if we can do this. You added a null-check already to prevent BV to validate for example
Collections. So adding this fallback will probably break this, right?

> Bean Validation doesn't work with Glassfish el-impl-2.2
> -------------------------------------------------------
>
>                 Key: MYFACES-3049
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3049
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: JSR-314
>    Affects Versions: 2.0.4
>         Environment: Tomcat 2.0.29
>            Reporter: Jan-Kees van Andel
>
> I have this expression in my Facelet: #{newPaymentBean.payment.toAccount}
> "payment" resolves to the following:
> @Entity
> public class Payment implements Serializable {
>     // More stuff...
>     @NotNull @AccountNumber private String toAccount;
>     // More stuff...
> }
> When debugging in javax.faces.validator._BeanValidatorUELUtils, I noticed the following
on line 47 "ValueReference valueReference = valueExpression.getValueReference(elCtx);":
> * With Glassfish EL, "valueReference.property" is null. This causes the BeanValidator
to return at line 161, and to skip validation. "valueReference.base" points to the Payment
object btw.
> * With JUEL 2.2.3, "valueReference.property" is "toAccount", which is correct AFAIK.
> I'm not sure whether this is a MyFaces or EL issue. I remember that when I wrote the
BeanValidator, that the spec literally said what to do. See: http://javaserverfaces.java.net/nonav/docs/2.0/javadocs/javax/faces/validator/BeanValidator.html#validate(javax.faces.context.FacesContext,
javax.faces.component.UIComponent, java.lang.Object)
> So I guess this is an EL implementation issue, but I filed it nevertheless, at least
for archiving purposes...
> WDYT?

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message