myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeanne Waldman (JIRA)" <...@myfaces.apache.org>
Subject [jira] Resolved: (TRINIDAD-2015) log css parse errors at their source and skip to avoid IllegalArgumentException in FileSystemStyleCache
Date Tue, 25 Jan 2011 17:54:43 GMT

     [ https://issues.apache.org/jira/browse/TRINIDAD-2015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jeanne Waldman resolved TRINIDAD-2015.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0.0-beta-1
         Assignee: Jeanne Waldman

> log css parse errors at their source and skip to avoid IllegalArgumentException in FileSystemStyleCache
> -------------------------------------------------------------------------------------------------------
>
>                 Key: TRINIDAD-2015
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2015
>             Project: MyFaces Trinidad
>          Issue Type: Improvement
>          Components: Skinning
>            Reporter: Jeanne Waldman
>            Assignee: Jeanne Waldman
>             Fix For: 2.0.0-beta-1
>
>
> There was a typo in a css file and we got an IllegalArgumentException
> that Selector was null. It would have been more helpful if we got an error
> earlier in the code at parse time so we know what css file had the parse
> error. 
> The typo was like there was an extra ',' at the end of the selector list. This created
a selector with the name "".
> .abc, .cde, .efg, {color: red}
> Do not add the empty selector to the list of selectors. Skip it. This will avoid the
IllegalArgumentException in FileSystemStyleCache.
> java.lang.IllegalArgumentException: selectorString must be non null and non
> empty.
> at
> org.apache.myfaces.trinidad.style.Selector.createSelector(Selector.java:48)
> at
> org.apache.myfaces.trinidadinternal.style.cache.FileSystemStyleCache$StylesImp
> l.<init>(FileSystemStyleCache.java:1348)
> at 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message