myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Leonardo Uribe (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (MYFACES-3002) FaceletComponsitionContextImpl drops viewParams
Date Tue, 11 Jan 2011 20:16:47 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980310#action_12980310
] 

Leonardo Uribe commented on MYFACES-3002:
-----------------------------------------

Ok, so we can close this issue. f:metadata should be on the topmost layer as says the facelets
tld javadoc of f:metadata :

"....Declare the metadata facet for this view. This must be a child of the <f:view>.
This tag must reside within the top level XHTML file for the given viewId, or in a template
client, but not in a template...".

Right now if the component parent passed to f:metadata is not UIViewRoot, an exception is
thrown, but this condition is only checked when viewMetadata is being built. I think we just
check that condition always is enough. I'll close this issue as fixed.

> FaceletComponsitionContextImpl drops viewParams
> -----------------------------------------------
>
>                 Key: MYFACES-3002
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3002
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: JSR-314
>    Affects Versions: 2.0.2, 2.0.3
>            Reporter: Mark Struberg
>            Assignee: Jakob Korherr
>            Priority: Critical
>
> This is related to MYFACES-2774
> FaceletComponsitionContextImpl#finalizeForDeletion drops the 'javax_faces_metadata' from
the UIViewRoot s _facetMap. Thus all 'old' viewParams are not available for propagation to
the next view anymore.
> This situation happens if an action returns something like
> > return "nextPage.xhtml??faces-redirect=true&includeViewParams=true";

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message