myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Blake Sullivan (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (TRINIDAD-2011) RowKeySet Attribute Changes surprisingly change object identity
Date Tue, 25 Jan 2011 19:16:44 GMT

    [ https://issues.apache.org/jira/browse/TRINIDAD-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986621#action_12986621
] 

Blake Sullivan commented on TRINIDAD-2011:
------------------------------------------

Fixed in Trinidad 1.2.x in revision 1063408


> RowKeySet Attribute Changes surprisingly change object identity
> ---------------------------------------------------------------
>
>                 Key: TRINIDAD-2011
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2011
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 1.2.13-core , 1.2.14-core , 2.0.0-alpha, 2.0.0-alpha-2
>            Reporter: Blake Sullivan
>            Assignee: Blake Sullivan
>             Fix For: 2.0.0-beta-1
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Whenever the ChangeManager restores a RowKeySet, it changes the identity of the underlying
object.  This surprises application developers who may have held onto the original instance
in order to mutate it and results in the wrong objects being used by the application in many
cases.  The solution is to preserve the object identity in all cases by reusing the existing
RowKeySet and simply clearing it and then adding the new values.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message