Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "MyFaces Development" <dev@myfaces.apache.org>
Received-SPF: pass (athena.apache.org: local policy)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=yahoo.com;
  h=DKIM-Signature:Received:X-Yahoo-SMTP:X-YMail-OSG:X-Yahoo-Newman-Property:From:Content-Type:Content-Transfer-Encoding:Subject:Date:Message-Id:To:Mime-Version:X-Mailer;
  b=So2B2w6nC2453MiS62WhRtOifQpAdyjiON5SSRIgPstrAzDdWe4x5zYDcAnjX0JouG2qzOrPOi/uZBWEkzm6H+P3q8xqZp74VAJi+uRRbsatCjYHtSJZr8Tlj2n6pzkWsr3fxLUr6hBZcwcSrbcHwQTLsLXEMCdM86MCRQhVZsk=
  ;
From: David Jencks <david_jencks@yahoo.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Subject: Possible problem in FacesConfig ordering
Date: Fri, 3 Dec 2010 14:43:24 -0800
Message-Id: <FEAA7E9D-FCB8-4648-AC60-982BE83E9D28@yahoo.com>
To: MyFaces Development <dev@myfaces.apache.org>
Mime-Version: 1.0 (Apple Message framework v1081)

I'm finding a tck problem around FacesConfig ordering.  I haven't =
figured out if this is caused by the geronimo integration or myfaces =
itself but I think there's something odd in the myfaces code.

DefaultFacesConfigurationProvider line 461 has

                    =
getDispenser().feed(getFacesConfig(appConfigResources, =
nameSlot.getName()));


getFacesConfig can return null if it doesn't find a FacesConfig with the =
supplied name:

    private FacesConfig getFacesConfig(List<FacesConfig> =
appConfigResources, String name)
    {
        for (FacesConfig cfg: appConfigResources)
        {
            if (cfg.getName() !=3D null && name.equals(cfg.getName()))
            {
                return cfg;
            }
        }
        return null;
    }


but the feed method starts off:

    public void feed(FacesConfig config)
    {
        for (Factory factory : config.getFactories())


assuming a non-null argument.

Whatever the cause of the null I'm seeing returned from getFacesConfig =
this doesn't seem right.

thanks
david jencks