myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jakob Korherr (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (MYFACES-2986) Provide an interface to override how to find spi interfaces
Date Wed, 01 Dec 2010 17:15:12 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12965748#action_12965748
] 

Jakob Korherr commented on MYFACES-2986:
----------------------------------------

1) OK, great! But please also change DefaultServiceLoaderFinder to DefaultServiceProviderFinder
(I think you forgot this one in your last commit)

2) Yes, in theory there should only be (maximum) one SPI impl per SPI, however a user may
misconfigure his classpath or copy/paste the wrong code and thus get two SPI impls for one
SPI. In this case it is not clear what happens, so we should really throw an exception (at
least when running in development mode).

> Provide an interface to override how to find spi interfaces
> -----------------------------------------------------------
>
>                 Key: MYFACES-2986
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2986
>             Project: MyFaces Core
>          Issue Type: Improvement
>          Components: JSR-314
>    Affects Versions: 2.0.2
>            Reporter: Leonardo Uribe
>            Assignee: Leonardo Uribe
>             Fix For: 2.0.3-SNAPSHOT
>
>         Attachments: MYFACES-2986-2.patch
>
>
> This is the last step to solve MYFACES-2944 and MYFACES-2945 problem related to OSGi
and SPI. Now it is possible to call 
> ServiceLoaderFinderFactory.setServiceLoaderFinder(ExternalContext ectx, ServiceLoaderFinder
slp)
> or 
> ServiceLoaderFinderFactory.setServiceLoaderFinder(ServletContext ctx, ServiceLoaderFinder
slp)
> Just before initialization to set a ServiceLoaderFinder that will be used later to locate
SPI interfaces. In this way, it is possible to provide a code that looks SPI interfaces using
OSGi bundles.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message