myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From <neum...@ijet.com>
Subject RE: Required Label Marker Placement
Date Thu, 04 Nov 2010 13:47:24 GMT
I haven't disappeared. Just very busy with the paying job and life. 
I have made the changes to work for me and it looks great but have not had time to work with
the unit tests. 
 
Just an FYI, this change did require that I pass a boolean 'required' flag along through the
'applyMarker's chain of methods, since we are marking both required and unrequired fields.

I'm not aware of a better aproach at this time. Any thoughts?
 
BEFORE_WITH_DUMMY sounds perfect. 
 
Thanks!
Ben
 

-----Original Message-----
From: Rudy De Busscher [mailto:rdebusscher@gmail.com]
Sent: Thursday, November 04, 2010 9:21 AM
To: MyFaces Development
Subject: Re: Required Label Marker Placement


Hi,

We should make it configurable and use BEFORE_WITH_DUMMY (or something) instead of BEFORE.

I'll make the changes next week, or if you like, you can send us a patch that we can use.

regards
Rudy.



On 28 October 2010 18:36, Gerhard < gerhard.petracek@gmail.com> wrote:


+1 
i'll review and apply the patch as soon as you have finished the mentioned features.

regards,
gerhard

http://www.irian.at

Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German

Professional Support for Apache MyFaces




2010/10/28 < neumanb@ijet.com> 


Hi all. 
I've been playing with the required label addon and have found that a modification in marker
rendering has 
improved the appearance of my app. 
I just want to get feedback from the rest as to whether this might be a change worth integrating
into your module.
 
Essentially, the current implementation simply prepends the marker to the label (when applying
marker before value).
Visually, I do not like my required marker displacing the label. I would prefer that all labels,
required and otherwise, align vertically based on the label text, and that the required markers
appear left of this vertical alignment.
As so:
*First Name:
*Last Name:
 Middle Name:
 
In order to do this, I've prepended the required marker where necessary and a space where
not necessary. 
I have also set the font of the 'marker' to monospace.
 
Would this be a worthy addition to the addon? We could of course allow the developer to turn
this off through some configuration param.
 
Thanks!
Ben Neuman
 
 
 
 




Mime
View raw message