myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Leonardo Uribe (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (MYFACES-2944) Make those add*** methods public in WebXml
Date Thu, 04 Nov 2010 02:00:55 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12928087#action_12928087
] 

Leonardo Uribe commented on MYFACES-2944:
-----------------------------------------

I have attached a patch for this feature. The idea is provide the following interface:

public abstract class WebConfigProvider
{

   public abstract List<ServletMapping> getFacesServletMappings(ExternalContext externalContext);

    public abstract boolean isErrorPagePresent(ExternalContext externalContext);
    
}

Based on the previous argumentation there is no need for any more methods, so I think in this
part it is enough.

If no objections I'll commit this code soon.

> Make those add*** methods public in WebXml
> ------------------------------------------
>
>                 Key: MYFACES-2944
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2944
>             Project: MyFaces Core
>          Issue Type: Improvement
>          Components: General
>    Affects Versions: 2.0.2
>            Reporter: Ivan
>            Assignee: Jakob Korherr
>             Fix For: 2.0.3-SNAPSHOT
>
>         Attachments: MYFACES-2944-core-2.patch, MYFACES-2944-core.patch, MYFACES-2944-shared-2.patch,
MYFACES-2944-shared.patch, MYFACES-2944.patch
>
>
> In the Geronimo integration work, we have an internal structure for the parsed web.xml
file, and we hope to use that instance to fill in the org.apache.myfaces.shared.webapp.webxml.WebXml,
so that myfaces does not need to parse the web.xml file again, But those add*** method are
package scope. 
> Is it possible to make those methods public, I did not see it will break anyting.
> Thanks

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message