myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Kočí (JIRA) <...@myfaces.apache.org>
Subject [jira] Commented: (MYFACES-2968) ApplicationImpl.createMethodBinding should create expression with signature: void method(params)
Date Wed, 10 Nov 2010 16:02:18 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-2968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930632#action_12930632
] 

Martin Kočí commented on MYFACES-2968:
--------------------------------------

Are you sure that Application action is related to ApplicationImpl.createMethodBinding? I
don't see any usage of createMethodBinding in myfaces codebase.  Application action is implemented
as org.apache.myfaces.application.ActionListenerImpl. 


I think createMethodBinding and createValueBinding are methods from jsf 1.0 world and from
javax.faces.el - they are  are simple predecessor of ExpressionFactory.createXYZ from unified
EL.

But, if your statement is true, then the difference must be in underlying EL implementation
- I'll investigate it more.


> ApplicationImpl.createMethodBinding should create expression with signature: void method(params)
> ------------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-2968
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2968
>             Project: MyFaces Core
>          Issue Type: Bug
>            Reporter: Martin Kočí
>         Attachments: MYFACES-2968.patch
>
>
> This is probably not specified but mojarra does it: Application.createMethodBinding creates
method expression with void return type. That makes sence because original purpose of MethodBinding
is a reference to faces listeners and they are without return values mostly.
> o.a.m.ApplicationImpl creates value expression to method with Object return type.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message