myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jakob Korherr (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (MYFACES-2976) Support hiding myfaces impl classes in osgi, and provide a single osgi bundle for api + impl
Date Fri, 26 Nov 2010 10:41:14 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-2976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12935967#action_12935967
] 

Jakob Korherr commented on MYFACES-2976:
----------------------------------------

I just committed the patch to create the OSGi bundle.

David, can you please test this again? If everything works well with Geronimo, I will resolve
this issue! Thanks!

> Support hiding myfaces impl classes in osgi, and provide a single osgi bundle for api
+ impl
> --------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-2976
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2976
>             Project: MyFaces Core
>          Issue Type: Improvement
>          Components: Extension Feature
>    Affects Versions: 2.0.3-SNAPSHOT
>            Reporter: David Jencks
>            Assignee: Jakob Korherr
>         Attachments: MYFACES-2976-osgi-bundle.patch, MYFACES-2976.diff
>
>
> The current osgi solution of using require-bundle between the api and impl jars is generally
thought of as osgi worst-practice and just doesn't work with snapshot versions (presumably
a bug in the bundle plugin).
> Also this does not easily support hiding the impl classes.
> Geronimo would like to use a single bundle containing both api and impl and hide the
impl classes as much as possible.  This requires some slight modifications to the FactoryFinder
so that impl classes can be loaded from the same classloader as FactoryFinder if they are
not visible to the context class loader.
> I think myfaces would be the best place for this combined bundle but geronimo can build
it if necessary.  The FactoryFinder classloader changes are therefore more important.
> I've suggested a module name which maps to the bundle symbolic name well, as this seems
to be the preferred maven/osgi strategy at apache.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message