myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jakob Korherr (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (MYFACES-2944) Make those add*** methods public in WebXml
Date Thu, 28 Oct 2010 09:20:06 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925758#action_12925758
] 

Jakob Korherr commented on MYFACES-2944:
----------------------------------------

Please also add this method to WebConfig:

protected boolean isFacesServlet(Class<?> servletClass) {
        return FacesServlet.class.isAssignableFrom(servletClass) || DelegatedFacesServlet.class.isAssignableFrom(servletClass)
|| servletClass.getName().equals(getDelegateFacesServlet());
    } 

It will make the life of SPI providers easier!


Also: how are you planning to include the isOld() or the update() methods?

> Make those add*** methods public in WebXml
> ------------------------------------------
>
>                 Key: MYFACES-2944
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2944
>             Project: MyFaces Core
>          Issue Type: Improvement
>          Components: General
>    Affects Versions: 2.0.2
>            Reporter: Ivan
>            Assignee: Jakob Korherr
>             Fix For: 2.0.3-SNAPSHOT
>
>         Attachments: MYFACES-2944-core.patch, MYFACES-2944-shared.patch, MYFACES-2944.patch
>
>
> In the Geronimo integration work, we have an internal structure for the parsed web.xml
file, and we hope to use that instance to fill in the org.apache.myfaces.shared.webapp.webxml.WebXml,
so that myfaces does not need to parse the web.xml file again, But those add*** method are
package scope. 
> Is it possible to make those methods public, I did not see it will break anyting.
> Thanks

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message