Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "MyFaces Development" <dev@myfaces.apache.org>
Message-ID: <4425820.114501283344494289.JavaMail.jira@thor>
Date: Wed, 1 Sep 2010 08:34:54 -0400 (EDT)
From: "Denis A. (JIRA)" <dev@myfaces.apache.org>
To: dev@myfaces.apache.org
Subject: [jira] Commented: (TOMAHAWK-1544)
 org.apache.myfaces.custom.date.HtmlDateRenderer.encodeEnd() broken when no
 converter is used
In-Reply-To: <9218744.113341283333935114.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/TOMAHAWK-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905009#action_12905009 ] 

Denis A. commented on TOMAHAWK-1544:
------------------------------------

problematic code seems to have been added in the following commits:

r745285 | lu4242 | 2009-02-17 23:52:58 CET

TOMAHAWK-1014 HTMLInputDate ignores custom converters
----------------------------------------------------------------------------
r745124 | lu4242 | 2009-02-17 16:42:47 CET

TOMAHAWK-1014 HTMLInputDate ignores custom converters (changed decode and encodeEnd so converters can be set).
----------------------------------------------------------------------------

as a result there is always a DateTimeConverter, but if converter="" is not specified the t:inputDate fail on the validation step

> org.apache.myfaces.custom.date.HtmlDateRenderer.encodeEnd() broken when no converter is used
> --------------------------------------------------------------------------------------------
>
>                 Key: TOMAHAWK-1544
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1544
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Date
>    Affects Versions: 1.1.9
>            Reporter: Denis A.
>         Attachments: TOMAHAWK-1544_bugfix_patch.txt
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> the problem is in the decoding of date:
>                     if (token.startsWith("year="))
>                     {
>                         userData.setYear(token.substring(5));
>                     }
>                     if (token.startsWith("month="))
>                     {
>                         userData.setYear(token.substring(6));
>                     }
>                     if (token.startsWith("day="))
>                     {
>                         userData.setYear(token.substring(4));
>                    .....
> userData.setYear() is called for each case, while it should be setMonth(), setDay() and so on.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.