Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "MyFaces Development" <dev@myfaces.apache.org>
Message-ID: <11438718.327671285102534854.JavaMail.jira@thor>
Date: Tue, 21 Sep 2010 16:55:34 -0400 (EDT)
From: "Andrew Robinson (JIRA)" <dev@myfaces.apache.org>
To: dev@myfaces.apache.org
Subject: [jira] Updated: (TRINIDAD-1861) Add implementations for
 getCurrentPhaseId()/setCurrentPhaseId() to MockFacesContext12
In-Reply-To: <19994449.528151279838153040.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/TRINIDAD-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Robinson updated TRINIDAD-1861:
--------------------------------------

           Status: Resolved  (was: Patch Available)
    Fix Version/s: 2.0.0.3-core
       Resolution: Fixed

Applied the patch

> Add implementations for getCurrentPhaseId()/setCurrentPhaseId() to MockFacesContext12
> -------------------------------------------------------------------------------------
>
>                 Key: TRINIDAD-1861
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1861
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 2.0.0.3-core
>         Environment: Windows 7, JSF 2
>            Reporter: Pavitra Subramaniam
>             Fix For: 2.0.0.3-core
>
>         Attachments: trinidad-patch-1861.patch
>
>
> From Andy Schwartz:
> The Trinidad unit tests use Shale Test. Shale Test's mock objects are stuck back on JSF 1.1 APIs.
> We work around this by providing our own subclasses of some of these mock objects.
> For the FacesContext mock object, we use Trinidad's org.apache.myfaces.trinidadbuild.test.MockFacesContext12.
> MockFacesContext12 adds implementations for methods added in JSF 1.2 + 2.0.
> We missed two methods:
> - getCurrentPhaseId()
> - setCurrentPhaseId()
> Since we do not implement these methods, we end up inheriting the base implementations provided by javax.faces.context.FacesContext.
> The default implementations provided by FacesContext throw UnsupportedOperationExceptions.
> The fix is to add implementations for getCurrentPhaseId()/setCurrentPhaseId() to MockFacesContext12.
> We will likely also want to call FacesContext.setCurrentPhaseId(PhaseId.RENDER_RESPONSE) from RenderKitTestCase$BaseTest.setUp() so that getCurrentPhaseId() does not return null.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.