myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Leonardo Uribe (JIRA)" <...@myfaces.apache.org>
Subject [jira] Reopened: (MYFACES-2919) LifecycleProvider Based Problems and Tomcat7 LifeCycleProvider Support
Date Tue, 14 Sep 2010 20:42:36 GMT

     [ https://issues.apache.org/jira/browse/MYFACES-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Leonardo Uribe reopened MYFACES-2919:
-------------------------------------


I have some questions about this patch:

1. Why some code has changed to swallow all Throwable exceptions? If we change it to have
one LifecycleProvider per webapp it is not valid the argument proposed.
2. What will happen in a Tomcat 6 environment since we changed the entry on META-INF/services?
3. Why there was uncommented some code on ResourceAnnotationLifecycleProvider?

This issue is preventing me for do a release, and in my opinion we should revert it and examine
more carefully the consequences of the same. There are too many questions left and we need
to check them one by one.

> LifecycleProvider Based Problems and Tomcat7 LifeCycleProvider Support
> ----------------------------------------------------------------------
>
>                 Key: MYFACES-2919
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2919
>             Project: MyFaces Core
>          Issue Type: Bug
>            Reporter: Gurkan Erdogdu
>            Assignee: Jakob Korherr
>             Fix For: 2.0.2-SNAPSHOT
>
>         Attachments: MYFACES-2919-2.patch, patch.txt
>
>
> Patch content
> ----------------------
> 1- ResourceAnnotationLifecycleProvider : It does not check super class for annotations.
It must examine super classes. This is specificed in Java EE 6 specification, EE 5.2.5 Annotations
and Injections.
> 2- TomcatAnnotationLifecycleProvider : isAvailable Method must catch "Throwable" and
ignore them. Otherwise, it throws error/s that are not catched and calling code is not able
to process other lifecycle providers.
> 3- StartupServletContextListener : Early initiliazation of lifecycle provider. Otherwise,
it is not possible to use META-INF/services providers.
> 4- pom.xml : Adding Tomcat 7 libs.
> 5- Tomcat7AnnotationLifecycleProvider : Tomcat 7 based LifeCycleProvider implementation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message