Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "MyFaces Development" <dev@myfaces.apache.org>
Message-ID: <32387137.229451281339676443.JavaMail.jira@thor>
Date: Mon, 9 Aug 2010 03:41:16 -0400 (EDT)
From: =?utf-8?Q?Matthias_We=C3=9Fendorf_=28JIRA=29?= <dev@myfaces.apache.org>
To: dev@myfaces.apache.org
Subject: [jira] Commented: (TRINIDAD-1877) visitTree API issues for
 UIXIterator (stamping components)  in Trinidad 1.2.12.3 and Trunk
In-Reply-To: <2624430.226361281305356741.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/TRINIDAD-1877?page=3Dcom.atlass=
ian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1=
2896472#action_12896472 ]=20

Matthias We=C3=9Fendorf commented on TRINIDAD-1877:
----------------------------------------------

the 1.2.x branch should be patched as well, since that's where 1.2.x releas=
e are made from..

> visitTree API issues for UIXIterator (stamping components)  in Trinidad 1=
.2.12.3 and Trunk
> -------------------------------------------------------------------------=
-----------------
>
>                 Key: TRINIDAD-1877
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1877
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>    Affects Versions:  1.2.12-core
>         Environment: All
>            Reporter: Kamran Kashanian
>         Attachments: visitTree.patch
>
>
> There are different implementations of visitTree API in Trinidad Trunk an=
d 1.2.12.x.   Both implementations have problems with visiting the children=
 of 'stamping' components (UIXIterator, UIXTable, UIXTree, etc). =20
> For example in 1.2.12.3 branch a PPRed stamped child of a UIXIterator can=
 fail to render (never gets visited during encoding) because visitTree neve=
r establishes the parent component's 'currency' before visiting the childre=
n.
> In Trunk,  the UIXIterator's implementation of visitTree assumes that the=
 direct children of UIXIterator are always non-stamped columns and skips ov=
er visiting the direct children (goes directly to grand-children) when visi=
ting stamped children.  This assumption is incorrect for UIXIterator  (when=
 component is not a UIXTable/UIXTreeTable).
> Attaching a proposed fix to address the issue in 1.2.12.3.  The patch ove=
rrides the visitTree API in UIXIterator and establishes the correct 'curren=
cy' before visiting the children of UIXIterator.   Appreciate a review and =
feedback.

--=20
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.