Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "MyFaces Development" <dev@myfaces.apache.org>
Message-ID: <20742134.370881281982765088.JavaMail.jira@thor>
Date: Mon, 16 Aug 2010 14:19:25 -0400 (EDT)
From: "Leonardo Uribe (JIRA)" <dev@myfaces.apache.org>
To: dev@myfaces.apache.org
Subject: [jira] Reopened: (MYFACES-2858) pointless oamsubmit inline
 rendering (patch available)
In-Reply-To: <1904206.155951280919496317.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/MYFACES-2858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leonardo Uribe reopened MYFACES-2858:
-------------------------------------


We have to review first what happen if tomahawk + mojarra is used. Note in this case oamSubmit.js is not on the classpath.

I think if myfaces is used, we could include oamSubmit.js inside our jsf.js, but if mojarra is used, include it on a separate file as part of tomahawk and add it inline as shown.

> pointless oamsubmit inline rendering (patch available)
> ------------------------------------------------------
>
>                 Key: MYFACES-2858
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2858
>             Project: MyFaces Core
>          Issue Type: Improvement
>    Affects Versions: 2.0.2-SNAPSHOT
>            Reporter: Werner Punz
>             Fix For: 2.0.2-SNAPSHOT
>
>         Attachments: https___issues_apache_org_jira_browse_MYFACES-2858_externalizing_oamsubmit__.patch
>
>
> We have had several functions rendered inline for ages, namely appendHiddenInput oamSubmit, the autoscroll stuff etc...
> I personally think the rendering of those functions as inline scripts is pointless, blows up the browsers tremendously and
> prevents that the affected scripts can be browser cached.
> A quick look at the code revealed that there is basically nothing which would prevent to externalize the scripts. My main problem is where to we handle the auto append code.
> My personal guess is we probably simply should add it as a resource definitions to the commandLink, Button etc.. renderers, any ideas regarding this?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.