Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "MyFaces Development" <dev@myfaces.apache.org>
Received-SPF: pass (athena.apache.org: local policy)
Subject: Re: Myfaces vs. mojarra restore view performance
From: Martin Koci <martin.koci@aura.cz>
To: MyFaces Development <dev@myfaces.apache.org>
In-Reply-To: <1280780452.2985.124.camel@markoc-desktop>
References: <1280767443.2985.80.camel@markoc-desktop>
	 <AANLkTin6+p3ivDp+TAD+antaboJoDzFrhf7Z3SpYtHp=@mail.gmail.com>
	 <1280780452.2985.124.camel@markoc-desktop>
Content-Type: text/plain; charset="UTF-8"
Date: Tue, 03 Aug 2010 13:32:43 +0200
Message-ID: <1280835163.2985.171.camel@markoc-desktop>
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit

https://issues.apache.org/jira/browse/MYFACES-2854

Martin Koci píše v Po 02. 08. 2010 v 22:20 +0200:
> Hi,
> 
> quick results: yourkitprofiler marks as hot spot
> UiViewRoot.addComponentResource (3381 invocation count) - that method
> itself creates 5 710 511 invocations of AbstractIterator.next() 
> 
> Reason probably is that I have  custom renderer for UInput with
> @ResourceDependencies(...many @ResourceDependecy here).
> 
> All invocations comes from
> org.apache.myfaces.view.facelets.tag.jsf.ComponentTagHandlerDelegate.apply recursively during restore view - VDL.buildView. 
> 
> Solution: @ResourceDependencies is static structure and cannot change
> during lifecycle - call addComponentResource for particular type of
> component (renderer, validator, ...) only once per one lifecycle ?
> 
> 
> Thanks,
> 
> Martin Kočí
> 
> Jan-Kees van Andel píše v Po 02. 08. 2010 v 19:18 +0200:
> > Hey,
> > 
> > 
> > I'm very interested in the details behind those 750ms. Can you post
> > the hotspots? Like: number of invocations, ms. self time and ms. total
> > time.
> > 
> > 
> > Thanks.
> > 
> > 
> > Regards,
> > Jan-Kees
> > 
> > 
> > 2010/8/2 Martin Koci <martin.koci@aura.cz>
> >         Hi,
> >         
> >         our profiling results show that myfaces are significantly
> >         slower in
> >         restore view phase:
> >         
> >         com.sun.faces.... LifeCycle .. restoreView : 80 ms
> >         
> >         o.a.m.RestoreViewExecutor : 750ms!
> >         
> >         This result is perfectly reproducible in our case. I profile
> >         it on a
> >         application real application  - I cannot post test case here.
> >         
> >         Configuration: myfaces or mojarra from trunk, partial state
> >         saving, a
> >         view with more than 200 UIInput components.
> >         
> >         
> >         Is it a known problem? I will provide more detailed profiling
> >         results
> >         later.
> >         
> >         Regards,
> >         
> >         Martin Kočí
> >         
> >         
> >         
> >         
> >         
> > 
> > 
> 
> 
>