myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matthias Wessendorf <mat...@apache.org>
Subject [TRINIDAD-1747] zip page state to reduce live memory
Date Tue, 10 Aug 2010 08:49:05 GMT
Hi,

TRINIDAD-1747 has not been finished on the trunk (JSF2 version) of
Trinidad. E.g. the newly introduced 'ObjectInputStreamResolveClass' is
missing there...
When I tried to patch Trinidad2 in the past with the 100% same version
of the patch, I was running into issues, when we forced Trinidad to do
"full client-side state-saving"
(not using 'token', but using its 'all' setting).

This never happened with JSF 1.2 version of Trinidad and also worked
fine with MyFaces 2.x, therefore I filed a bug against Mojarra ([1]),
which also provides some of the background.

Due to a change in Mojarra's ComponentStateHelper class (it stores
null values as Void.TYPE(s)) they suggested to implement a "mapping
table" as the vanilla ObjectInputStream from the JDK does. The
suggested fix does work 100%, so I ended up in borrowing some code
from Apache Harmony (due to licensing issues!) and made it fit.

I uploaded a modified version of the trunk (Trinidad2) patch (see
[2]). Please review, especially since I didn't write the original
version of the code.

Yes, the fix works fine with MyFaces 2.x and Mojarra 2.0.1

Greetings,
Matthias

[1] https://javaserverfaces.dev.java.net/issues/show_bug.cgi?id=1607
[2] https://issues.apache.org/jira/browse/TRINIDAD-1747


-- 
Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf

Mime
View raw message