myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan-Kees van Andel <jankeesvanan...@gmail.com>
Subject Proposal to stop using SVN Keywords - (was: MyFaces shipping with JBoss AS6?)
Date Mon, 09 Aug 2010 19:43:08 GMT
Hi,

What do you guys think about pruning the SVN keywords in the source files?

Matthias pointed out a nice example of an issue you run into with this
stuff.

1 Not everybody has (the same) svn:keywords on every file.
2 When 1, it will get out of sync.
3 Unreadable version numbers are pretty useless information (at least for
me).
4 If you need to know something about the revision history, SVN itself is a
much better place to look.
5 (I think) it looks messy in the source code.

Note that I'm not talking about removing everything in a major refactoring.
For now, I'm just proposing a convention for new code.
I'm also not proposing to remove the @author JavaDoc tag. That's a useful
one. I'm talking about the  "latest modification by $Author"  and  "@version
$Revision: 799929 $ $Date:.......$"  stuff.

What do you guys think?

Regards,
Jan-Kees



2010/8/9 Jan-Kees van Andel <jankeesvanandel@gmail.com>

> Yeah, I know. I'm so quick. I can edit files back in time. ;-)
>
> /JK
>
>
> 2010/8/9 Matthias Wessendorf <matzew@apache.org>
>
> + * @author Leonardo Uribe (latest modification by $Author: jankeesvanandel
>> $)
>>
>> + * @version $Revision: 799929 $ $Date: 2009-08-01 16:29:33 -0500
>> (sáb, 01 ago 2009) $
>>
>>
>>
>> did you copy that into your IDE template for new files? :-)
>>
>> -M
>>
>> On Mon, Aug 9, 2010 at 7:25 PM, Leonardo Uribe <lu4242@gmail.com> wrote:
>> > Hi Stan
>> >
>> > I have attached a proposal for this issue on:
>> >
>> > https://issues.apache.org/jira/browse/MYFACES-2860
>> >
>> > It includes the patch to be applied on myfaces, the project created to
>> do
>> > the integration, and the jsf deployer used in JBoss AS6 to give a try.
>> >
>> > It could be good to know what do yo think about it.
>> >
>> > best regards,
>> >
>> > Leonardo Uribe
>> >
>>
>>
>>
>> --
>> Matthias Wessendorf
>>
>> blog: http://matthiaswessendorf.wordpress.com/
>> sessions: http://www.slideshare.net/mwessendorf
>> twitter: http://twitter.com/mwessendorf
>>
>
>

Mime
View raw message