myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matthias We├čendorf (JIRA) <>
Subject [jira] Commented: (TRINIDAD-1877) visitTree API issues for UIXIterator (stamping components) in Trinidad and Trunk
Date Mon, 09 Aug 2010 07:41:16 GMT


Matthias We├čendorf commented on TRINIDAD-1877:

the 1.2.x branch should be patched as well, since that's where 1.2.x release are made from..

> visitTree API issues for UIXIterator (stamping components)  in Trinidad and
> ------------------------------------------------------------------------------------------
>                 Key: TRINIDAD-1877
>                 URL:
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>    Affects Versions:  1.2.12-core
>         Environment: All
>            Reporter: Kamran Kashanian
>         Attachments: visitTree.patch
> There are different implementations of visitTree API in Trinidad Trunk and 1.2.12.x.
  Both implementations have problems with visiting the children of 'stamping' components (UIXIterator,
UIXTable, UIXTree, etc).  
> For example in branch a PPRed stamped child of a UIXIterator can fail to render
(never gets visited during encoding) because visitTree never establishes the parent component's
'currency' before visiting the children.
> In Trunk,  the UIXIterator's implementation of visitTree assumes that the direct children
of UIXIterator are always non-stamped columns and skips over visiting the direct children
(goes directly to grand-children) when visiting stamped children.  This assumption is incorrect
for UIXIterator  (when component is not a UIXTable/UIXTreeTable).
> Attaching a proposed fix to address the issue in  The patch overrides the visitTree
API in UIXIterator and establishes the correct 'currency' before visiting the children of
UIXIterator.   Appreciate a review and feedback.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message