myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jakob Korherr (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (MYFACES-2858) pointless oamsubmit inline rendering (patch available)
Date Tue, 17 Aug 2010 09:15:16 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-2858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12899353#action_12899353
] 

Jakob Korherr commented on MYFACES-2858:
----------------------------------------

Acutally that's not true. It first was on api (in Werner's patch) and I moved it to impl,
because it is an implementation detail.

However you're right. I did not think about using tomahawk standalone with Mojarra. This will
currently not work. Thus putting it on shared may solve the problem, but I have to try this
first.

If you put them on jsf.js, the scenario tomahawk + mojarra also won't work. I will try some
scenarios and provide a patch afterwards!

> pointless oamsubmit inline rendering (patch available)
> ------------------------------------------------------
>
>                 Key: MYFACES-2858
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2858
>             Project: MyFaces Core
>          Issue Type: Improvement
>    Affects Versions: 2.0.2-SNAPSHOT
>            Reporter: Werner Punz
>             Fix For: 2.0.2-SNAPSHOT
>
>         Attachments: https___issues_apache_org_jira_browse_MYFACES-2858_externalizing_oamsubmit__.patch
>
>
> We have had several functions rendered inline for ages, namely appendHiddenInput oamSubmit,
the autoscroll stuff etc...
> I personally think the rendering of those functions as inline scripts is pointless, blows
up the browsers tremendously and
> prevents that the affected scripts can be browser cached.
> A quick look at the code revealed that there is basically nothing which would prevent
to externalize the scripts. My main problem is where to we handle the auto append code.
> My personal guess is we probably simply should add it as a resource definitions to the
commandLink, Button etc.. renderers, any ideas regarding this?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message