myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Struberg (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (MYFACES-2889) [PERF] Remove String.intern() calls in FlashELResolver and ImplicitObjectResolver
Date Sat, 21 Aug 2010 18:42:16 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-2889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901073#action_12901073
] 

Mark Struberg commented on MYFACES-2889:
----------------------------------------

Hi!

The problem with that is that you need to check all '==' comparisons because "xyz".intern()
== "xyz".intern() but "xyz" != "xyz"

intern is very usefully if something is compared really often.

> [PERF] Remove String.intern() calls in FlashELResolver and ImplicitObjectResolver
> ---------------------------------------------------------------------------------
>
>                 Key: MYFACES-2889
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2889
>             Project: MyFaces Core
>          Issue Type: Improvement
>          Components: JSR-314
>    Affects Versions: 2.0.2-SNAPSHOT
>         Environment: JBoss AS 6 M4, Parleys.com JSF2 app
>            Reporter: Jan-Kees van Andel
>
> I've been doing some profiling and I see pretty much activity in FlashELResolver.castAndIntern()
and ImplicitObjectResolver.castAndIntern().
> When I replace the "return s.intern()" lines by  "return s", both methods have (of course)
much better performance.
> But I'm pretty sure someone put them there with a reason, like memory footprint.
> However, I don't see any difference in memory footprint.
> Any ideas? Do we want to keep the intern() calls?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message