Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "MyFaces Development" <dev@myfaces.apache.org>
Received-SPF: pass (nike.apache.org: domain of gcjmu-myfaces-dev@m.gmane.org
 designates 80.91.229.12 as permitted sender)
To: dev@myfaces.apache.org
From: Werner Punz <werner.punz@gmail.com>
Subject: Re: Pending issues before release myfaces core 2.0.1
Date: Tue, 13 Jul 2010 19:52:19 +0200
Lines: 102
Message-ID: <i1i94k$c9f$1@dough.gmane.org>
References: <AANLkTimZ1xKwkfu89oquGQgGZiDYHQ5RxYA_4kBLIQNk@mail.gmail.com>
	<i1blcs$pk4$1@dough.gmane.org>	<i1elti$bes$1@dough.gmane.org>
	<4C3B26D6.1060501@gmail.com>	<i1fo5k$9ar$2@dough.gmane.org>
	<4C3B6FB2.9050101@gmail.com>	<i1fs9l$ol4$1@dough.gmane.org>
	<i1fsc7$ol4$2@dough.gmane.org>
	<AANLkTinLuwj40xyfWhah9W5D_urlfhgwJiODARj3BMm0@mail.gmail.com>
	<i1gri7$bis$1@dough.gmane.org>
	<AANLkTilViRN4TIb3Yjvf7CfKigMcQKL3B7Utrp8Yl8_g@mail.gmail.com>
	<i1h29t$s7r$1@dough.gmane.org>
	<AANLkTikJgO8e_5ztgxk7HeBy5ZY_smV7pFSsvjOoPVju@mail.gmail.com>
 <AANLkTim8SmMF0v_I6AenGhbTNY-JK-G7baU_pebmiLKN@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; de;
 rv:1.9.1.10) Gecko/20100512 Thunderbird/3.0.5
In-Reply-To: <AANLkTim8SmMF0v_I6AenGhbTNY-JK-G7baU_pebmiLKN@mail.gmail.com>

Hi no need anymore, I have found the root of the issue, somewhere along 
the full page refresh the view state is lost, the issue is within the 
realm of jsf.js.
I am going to fix the issue tomorrow morning.

Please do not release before I have fixed it, after that I will have no 
more issues pending.

Werne


Am 13.07.10 10:36, schrieb Jakob Korherr:
> Hi Leo,
>
> If you don't have time for it, let me know. Then I will take a look at it!
>
> Regards,
> Jakob
>
> 2010/7/13 Leonardo Uribe <lu4242@gmail.com <mailto:lu4242@gmail.com>>
>
>     Hi Werner
>
>     Ok, now I understand. Right now I'm working on enhance myfaces test,
>     but I'll dedicate some time to this one as well.
>
>     Leonardo
>
>     2010/7/13 Werner Punz <werner.punz@gmail.com
>     <mailto:werner.punz@gmail.com>>
>
>         Am 13.07.10 07:49, schrieb Leonardo Uribe:
>
>             Hi Werner
>
>             This seems to be an undocumented feature. I didn't knew
>             @form exists. It
>             doesn't appear on the draft of jsf 2.0 rev A. Anyway, we have to
>             implement it and tell to EG that is not documented.
>
>             regards,
>
>             Leonardo
>
>         Hi Leonardo, sorry for the misunderstanding, I will describe the
>         issue more clearly here, it is not @form (which is part of the
>         spec btw, see below) but a nav case fails, if done within a ppr
>         context. The issue is simply that if you navigate from page1 to
>         page 2 within a nav case it works but as soon as you want to
>         navigate back you are stuck on the on page2 if you have ppr
>         enabled for the navigation, (a render viewroot is issued however
>         correctly, but in the second page just for second page again)
>
>           the second navigation case within ppr simply fails, the @form
>         stuff is something which is resolved on the javascript side and
>         is unrelated to the issue.
>
>
>         Since navigation is vital ppr and outside of ppr I marked this
>         issue as stopper, I simply think 2.0.1 should not have this bug
>         anymore, because the overall quality of the build is so much better.
>
>         The @form attribute is btw. defined in the secion 14.2.2 of the
>         jsf2 spec and is javascript only, so no worries that you never
>         encountered it. It just means the element defined is the
>         enclosing form, in case of execute it means the entire form is
>         encoded and sent to the server, on the server side it never
>         shows up.
>
>
>         So here is the exact description of the failure
>
>         page1 navigate to page2 via an action and implicit navigation ->
>         page2 shows -> page2 should navigate back to page1 via an action
>         and implicit navigation -> page2 is rerendered again.
>
>         This only happens if you use f:ajax on the commandLinks and in
>         myfaces. Mojarra correctly switches back to page1.
>
>         I will debug into it I assume it is a bug in the nav handler
>         which has to treat the ppr case slightly differently, maybe I
>         will find it.
>
>
>
>
>
>
>         Werner
>
>
>
>
>
>
> --
> Jakob Korherr
>
> blog: http://www.jakobk.com
> twitter: http://twitter.com/jakobkorherr
> work: http://www.irian.at