Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "MyFaces Development" <dev@myfaces.apache.org>
Message-ID: <30220344.179771278100733356.JavaMail.jira@thor>
Date: Fri, 2 Jul 2010 15:58:53 -0400 (EDT)
From: =?utf-8?Q?Martin_Ko=C4=8D=C3=AD_=28JIRA=29?= <dev@myfaces.apache.org>
To: dev@myfaces.apache.org
Subject: [jira] Commented: (MYFACES-2688) when form is
 'multipart/form-data', form component will never process update.
In-Reply-To: <13362794.26921272607857686.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/MYFACES-2688?page=3Dcom.atlassi=
an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D12=
884793#action_12884793 ]=20

Martin Ko=C4=8D=C3=AD commented on MYFACES-2688:
--------------------------------------

h:inputFile is planned for JSF 2.1: https://javaserverfaces-spec-public.dev=
.java.net/issues/show_bug.cgi?id=3D690. I don't know exact plan for 2.1  bu=
t first milestone (without inputFile) is here: http://wiki.jcp.org/wiki/ind=
ex.php?page=3DJSF+2.1+Change+Log so it seems 2.1 is on the way.

Problem with missing multipart support has many consequencies: this issue, =
http://www.mail-archive.com/users@myfaces.apache.org/msg55998.html, JSF HTM=
L_BASIC does'nt cover all elements from HTML 4.01, user must use third part=
y uploads (which are incompatible) usw.=20

Solution from https://javaserverfaces-spec-public.dev.java.net/issues/show_=
bug.cgi?id=3D690 based on decorated ExternalContext.getRequestParameterMap(=
) (Neil's solution) works  without problem - I've adated it to servlet envi=
roment and it works: without a servlet filter, without any third party libr=
ary and doesn't lose request parameters with multipart request even they co=
mes from a conversation framework.

I hope this could be in myfaces core now and it does not break compatibilit=
y - if so I can provide a patch.


=20


> when form is 'multipart/form-data', form component will never process upd=
ate.
> -------------------------------------------------------------------------=
----
>
>                 Key: MYFACES-2688
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2688
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: JSR-314
>    Affects Versions: 2.0.0
>         Environment: mac os x, tomcat.
>            Reporter: Mark Li
>   Original Estimate: 120h
>  Remaining Estimate: 120h
>
> because 'javax.view.id' will not be find in request.getParametersMap, the=
 restore phase executor will stop execute.
> source code:
> package org.apache.myfaces.lifecycle;
> .........
> class RestoreViewExecutor implements PhaseExecutor
> ..........
>   public boolean execute(FacesContext facesContext){
> ..................
>          if (!errorPageRequest && restoreViewSupport.isPostback(facesCont=
ext)){
> ................
>           }
> ...............
>   }
> restoreViewSupport.isPostback(facesContext) will call facesContext.getExt=
ernalContext().getRequestParameterMap().get(ResponseStateManager.VIEW_STATE=
_PARAM)
> but  request.parameterMap is empty because of  using 'multipart/form-data=
'.
>  restoreViewSupport.isPostback(facesContext) will return false,
> then FacesContext.renderResponse() is called. the whole phasing process i=
s stopped.
> suggestion:
> should wrap request.parameterMap from the first place.

--=20
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.