Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "MyFaces Development" <dev@myfaces.apache.org>
Message-ID: <20656352.268901278624530430.JavaMail.jira@thor>
Date: Thu, 8 Jul 2010 17:28:50 -0400 (EDT)
From: "Jakob Korherr (JIRA)" <dev@myfaces.apache.org>
To: dev@myfaces.apache.org
Subject: [jira] Commented: (MYFACES-2744) UIData.getClientId() should not
 append rowIndex, instead use UIData.getContainerClientId()
In-Reply-To: <7864316.196821275715709638.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/MYFACES-2744?page=3Dcom.atlassi=
an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D12=
886488#action_12886488 ]=20

Jakob Korherr commented on MYFACES-2744:
----------------------------------------

Great! Yes of course, you're right. I did not think of that.

Now we can close the issue :)

> UIData.getClientId() should not append rowIndex, instead use UIData.getCo=
ntainerClientId()
> -------------------------------------------------------------------------=
-----------------
>
>                 Key: MYFACES-2744
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2744
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: JSR-314
>    Affects Versions: 2.0.0
>            Reporter: Leonardo Uribe
>            Assignee: Jakob Korherr
>             Fix For: 2.0.1-SNAPSHOT
>
>
> from: [jsr-314-open] Ajax inside a DataTable
> Cagatay Civici
> I've faced with an issue in our app I'd like to share when trying to upda=
te the datatable itself from a command element located inside a column. Cas=
e is to select a row, execute logic and update the datatable. Basic code:
> <h:dataTable id=3D"cars" var=3D"car" value=3D"#{tableBean.carsSmall}">
> <h:column>
> <f:facet name=3D"header">
> Model
> </f:facet>
> <h:outputText value=3D"#{car.model}" />
> </h:column>
> <h:column>
> <f:facet name=3D"header">
> Action
> </f:facet>
> <h:commandButton value=3D"Some Action" actionListener=3D"#{tableBean.hand=
leRowAction(car)}">
> <f:ajax render=3D"cars" />
> </h:commandButton>
> </h:column>
> </h:dataTable>
> As datatable has a rowIndex >=3D 0 during rendering of commandButton f:aj=
ax defines the component id to render as cars:{rowIndex} where I should exp=
ect "cars" only. This is due to UIData.getClientId implementation as UIData
> adds rowIndex for unique row ids. This causes an issue with a nested f:aj=
ax case.
> Martin Marinschek
> We should never include the row-index in the client-id of the table
> itself. For this, we need to revise the client-id generation
> algorithm.
> Without actually having tried it, I think that it is easy to do so, as
> we have a UIComponentBase.getContainerClientId() to create the
> client-id of the children - when this method is called, we append the
> row-index, if getClientId() itself is called, we don=C2=B4t.=20

--=20
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.