Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "MyFaces Development" <dev@myfaces.apache.org>
Message-ID: <15530359.583391280137197693.JavaMail.jira@thor>
Date: Mon, 26 Jul 2010 05:39:57 -0400 (EDT)
From: "Jakob Korherr (JIRA)" <dev@myfaces.apache.org>
To: dev@myfaces.apache.org
Subject: [jira] Commented: (MYFACES-2839) cleanup of UIInput
In-Reply-To: <26812573.582031280133710112.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/MYFACES-2839?page=3Dcom.atlassi=
an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D12=
892235#action_12892235 ]=20

Jakob Korherr commented on MYFACES-2839:
----------------------------------------

For _ExternalSpecifications there is already an issue in the JIRA: MYFACES-=
2582

> cleanup of UIInput
> ------------------
>
>                 Key: MYFACES-2839
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2839
>             Project: MyFaces Core
>          Issue Type: Improvement
>    Affects Versions: 2.0.1
>            Reporter: Matthias We=C3=9Fendorf
>            Priority: Minor
>
> looking at shouldValidateEmptyFields() I see this code:
> ...
>        ExternalContext extCtx =3D context.getExternalContext();
>        String validateEmptyFields =3D (String)
> extCtx.getInitParameter(VALIDATE_EMPTY_FIELDS_PARAM_NAME);
>        if (validateEmptyFields =3D=3D null)
>        {
>            validateEmptyFields =3D (String)
> extCtx.getApplicationMap().get(VALIDATE_EMPTY_FIELDS_PARAM_NAME);
>        }
> ....
> =3D> Should be cached on application_map instead of always parsing the we=
b.xml (getInitParam())-
> Actually I don't see a put to stored it on the applcaitonMap;
> Inside of the validate() I see similar code:
> String contextParam =3D
> context.getExternalContext().getInitParameter(EMPTY_VALUES_AS_NULL_PARAM_=
NAME);
> =3D> not cached
> Similar in the _ExternalSpecifications clazz, no cache maintained here

--=20
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.