Return-Path: Delivered-To: apmail-myfaces-dev-archive@www.apache.org Received: (qmail 64340 invoked from network); 10 Jul 2010 23:08:44 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 10 Jul 2010 23:08:44 -0000 Received: (qmail 98955 invoked by uid 500); 10 Jul 2010 23:08:44 -0000 Delivered-To: apmail-myfaces-dev-archive@myfaces.apache.org Received: (qmail 98881 invoked by uid 500); 10 Jul 2010 23:08:43 -0000 Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "MyFaces Development" Delivered-To: mailing list dev@myfaces.apache.org Received: (qmail 98874 invoked by uid 99); 10 Jul 2010 23:08:43 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 10 Jul 2010 23:08:43 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 10 Jul 2010 23:08:41 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o6AN0oJK017939 for ; Sat, 10 Jul 2010 23:00:50 GMT Message-ID: <13977404.308511278802850563.JavaMail.jira@thor> Date: Sat, 10 Jul 2010 19:00:50 -0400 (EDT) From: "Leonardo Uribe (JIRA)" To: dev@myfaces.apache.org Subject: [jira] Commented: (MYFACES-2802) Remove CompositeComponentResourceTagHandler.ATTACHED_OBJECT_HADLERS_KEY from Attributes Map In-Reply-To: <32437268.280631278665751721.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/MYFACES-2802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887107#action_12887107 ] Leonardo Uribe commented on MYFACES-2802: ----------------------------------------- The idea looks good, but the patch shows this map: private static final Map> _attachedObjectHandlers = new HashMap>(); Instead use a map on a static variable, it is better to put it as a key on FacesContext attribute map, or even better, put it on org.apache.myfaces.view.facelets.FaceletCompositionContext (the intention is provide a context for facelets build, so this is the right place to put it). Note FaceletCompositionContext is already stored on FacesContext attribute map. > Remove CompositeComponentResourceTagHandler.ATTACHED_OBJECT_HADLERS_KEY from Attributes Map > ------------------------------------------------------------------------------------------- > > Key: MYFACES-2802 > URL: https://issues.apache.org/jira/browse/MYFACES-2802 > Project: MyFaces Core > Issue Type: Improvement > Components: General > Affects Versions: 2.0.0 > Reporter: Marius Petoi > Priority: Minor > Attachments: attachedObjectHandlers.patch > > > Another state saving improvement is to remove the attached object handlers from the component attributes map. Instead a map that holds the attached object handlers indexed by the component reference will be created in CompositeComponentResourceTagHandler. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.