myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Marinschek <mmarinsc...@apache.org>
Subject Re: [GSOC] State saving performance improvements in MyFaces 2.0
Date Tue, 06 Jul 2010 14:38:58 GMT
Hi Marius,

> So, I am not sure what you mean by map with the Reference of the component
> as the key...is it a map in which the keys are java.lang.ref.Reference
> objects? And if so, what kind of references should I use?

I meant you just put the component itself as a key there.

> On the other hand, regarding serialization vs implements PartialStateHolder,
> I've looked for some more externalizable objects: the TagMethodExpression
> class is used in the MethodExpressionValueChangeListener, which implements
> StateHolder and PartialMethodExpressionValueChangeListener, which implements
> PartialStateHolder.

> So maybe instead of being Externalizable,
> TagMethodExpression should also implement PartialStateHolder. There is a
> similar situation with TagValueExpression.

I guess - Leonardo should clarify.

best regards,

Martin

> On Tue, Jul 6, 2010 at 10:46 AM, Martin Marinschek <mmarinschek@apache.org>
> wrote:
>>
>> Hi Marius,
>>
>>
>> >>  problem here is since this call occur in build time, we can't call
>> >> getClientId() (it will cause problems because the parent for most
>> >> components
>> >> is null in this stage), so use a external map here
>> >> Why not use the Reference of the component as the key? Over one
>> >> request,
>> >> the reference is stable enough!
>> >
>> > Yes, it is possible. Just we have to take care about
>> > ClientBehaviorRedirectEventComponentWrapper, because this class is used
>> > as a
>> > wrapper to redirect client behavior events.
>> >
>> > Note that
>> > CompositeComponentResourceTagHandler.ATTACHED_OBJECT_HADLERS_KEY
>> > list is not saved on the state, but since we use the component attribute
>> > map, the key and the null value is saved on the state. If we don't use
>> > the
>> > component attribute map, we don't have that trace on the state and it
>> > will
>> > be lower.
>>
>> any update on this?
>>
>> best regards,
>>
>> Martin
>
>



-- 

http://www.irian.at

Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German

Professional Support for Apache MyFaces

Mime
View raw message