myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Leonardo Uribe (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (MYFACES-2774) Remove MARK_DELETED attribute from the component
Date Sat, 10 Jul 2010 23:48:50 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-2774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887118#action_12887118
] 

Leonardo Uribe commented on MYFACES-2774:
-----------------------------------------

I reviewed the patch and the idea is fine, just we need to adjust some details.

 The only possible enhancement I see is use a Map<UIComponent, Boolean> instead a List<UIComponent>
for _componentsMarkedForDeletion. I guess for addition and removal operations in this case
a HashMap is faster than an ArrayList.

Don't change the signature of javax.faces classes (the patch contains some additional methods
for FaceletContext). Instead, in myfaces we have a class called AbstractFaceletContext where
we have all methods that we need on FaceletContext, but we can't add them.

In theory we should try to use FaceletCompositionContext instead add methods on AbstractFaceletContext
(see MYFACES-2629 for details).

> Remove MARK_DELETED attribute from the component
> ------------------------------------------------
>
>                 Key: MYFACES-2774
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2774
>             Project: MyFaces Core
>          Issue Type: Improvement
>          Components: General
>    Affects Versions: 2.0.0
>            Reporter: Marius Petoi
>            Priority: Minor
>         Attachments: markDeletedFaceletContext.patch
>
>
> The ComponentSupport.MARK_DELETED attribute is used only inside one request. It doesn't
need to be saved in the state. It should be removed from the attributes of the component.
Instead a list of components marked for deletion should be included in the FaceletContext.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message