myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bruno Aranda (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (MYFACES-2836) HtmlResponseWriterImpl does not check if a CDATA section is already opened when writing the content of a script
Date Fri, 23 Jul 2010 09:36:51 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-2836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12891536#action_12891536
] 

Bruno Aranda commented on MYFACES-2836:
---------------------------------------

Werner said this in the mailing list:

"Btw. one issue about this, check if your fix does not break anything in the ppr case.
The problem is that the ppr responseWriter simply delegates the HtmlResponseWriterImpl, but
the issue is
that CDATA blocks are automatically opened before any html is rendered, any valid CDATA block
inside should not be swallowed but escaped in that case."

That is not a problem, as PartialResponseWriterImpl does not depend on HtmlResponseWriterImpl,
but on the superclass ResponseWriter, which is not affected by the patch.

> HtmlResponseWriterImpl does not check if a CDATA section is already opened when writing
the content of a script
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-2836
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2836
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: JSR-252
>    Affects Versions: 2.0.1
>            Reporter: Bruno Aranda
>             Fix For: 2.0.2-SNAPSHOT
>
>         Attachments: MUFACES-2836.patch
>
>
> Hi,
> When the default response writer writes a script, it includes CDATA tags around the body.
If the script is being written inside another CDATA section for some reason (Primefaces does
this in its partial response), then invalid XML is created.
> I attach patch for the fix to be reviewed, before I commit something not quite right
again and we can discuss. Basically, a simple boolean is used to check if a CDATA is already
open or not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message