myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Leonardo Uribe (JIRA)" <>
Subject [jira] Updated: (MYFACES-2850) Clean saved state of UIInput
Date Fri, 30 Jul 2010 18:58:19 GMT


Leonardo Uribe updated MYFACES-2850:

           Status: Resolved  (was: Patch Available)
         Assignee: Leonardo Uribe
    Fix Version/s: 2.0.2-SNAPSHOT
       Resolution: Fixed

I checked it and the patch had a small bug (use value instead key). On postback, every instance
of UIInput save the following values.


  [submittedValue, null, localValueSet, false, valid, true, value, null]


  Validation success : [localValueSet, false, value, null, submittedValue, null]
  Validation fail : [submittedValue, , valid, false]

So, with the change we reduce two slots (valid) when validation is succesful and four slots
(value, localValueSet) when validation fails. I think we can reduce even more the state if
the changes proposed to fix UIData component state MYFACES-2616 are introduced (with transient
variables, we can store this values there and just before save the state move it to the delta
stuff if necessary) but for now I think it is ok.

> Clean saved state of UIInput
> ----------------------------
>                 Key: MYFACES-2850
>                 URL:
>             Project: MyFaces Core
>          Issue Type: Improvement
>          Components: General
>    Affects Versions: 2.0.1
>            Reporter: Marius Petoi
>            Assignee: Leonardo Uribe
>            Priority: Minor
>             Fix For: 2.0.2-SNAPSHOT
>         Attachments: uiInputStateCleanup.patch
> The saved state of UIInput needs to be cleaned. The default values should not be saved.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message