myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Freedman (JIRA)" <...@myfaces.apache.org>
Subject [jira] Resolved: (PORTLETBRIDGE-150) ViewHandler.renderView should cache/reset ExteranlContext response object before delegating
Date Wed, 14 Jul 2010 21:13:55 GMT

     [ https://issues.apache.org/jira/browse/PORTLETBRIDGE-150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Michael Freedman resolved PORTLETBRIDGE-150.
--------------------------------------------

    Fix Version/s: 1.0.0
                   2.0.0
       Resolution: Fixed

Code has been checkedin on both trunks.

> ViewHandler.renderView should cache/reset ExteranlContext response object before delegating
> -------------------------------------------------------------------------------------------
>
>                 Key: PORTLETBRIDGE-150
>                 URL: https://issues.apache.org/jira/browse/PORTLETBRIDGE-150
>             Project: MyFaces Portlet Bridge
>          Issue Type: Bug
>    Affects Versions: 1.0.0-beta, 2.0.0-alpha
>            Reporter: Michael Freedman
>            Assignee: Michael Freedman
>             Fix For: 1.0.0, 2.0.0
>
>
> The bridge viewhandler by default delegates rendering.  However there are situations
where the delegatee will replace the response object in the ExternalContext and not clean/restore
this back to the original if an exception occurs.  As the bridge's viewhandler ignores exceptions
coming back from deletgatees this can lead to ClassCastException farther down the bridge rendering
code as it acquires the response and casts it to the expected Portlet response.  To avoid
this the bridge should get/cache the response object before delegating and then in the catch
block (i.e. if exception thrown) restore the response object if the current one isn't equal
to the cached one.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message