myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jakob Korherr (JIRA)" <...@myfaces.apache.org>
Subject [jira] Created: (MYFACES-2842) Refactor FlashImpl
Date Tue, 27 Jul 2010 17:01:19 GMT
Refactor FlashImpl
------------------

                 Key: MYFACES-2842
                 URL: https://issues.apache.org/jira/browse/MYFACES-2842
             Project: MyFaces Core
          Issue Type: Task
          Components: JSR-314
    Affects Versions: 2.0.1
            Reporter: Jakob Korherr
            Assignee: Jakob Korherr
         Attachments: flash_scope.png

We ran into some issues with the current Flash implementation in MyFaces CODI some days ago
and thus I started to bugfix and refactor it.

Overall the current FlashImpl has some bugs that are really only a reason of missing documentation
about the FlashScope. Thus I worked very hard to find out the right way to go, and I think
my refactorings really paid off, because now every possible scenario works for us (also verified
with Mojarra). Furthermore the code is now much better readable :)

Things I've changed:
 - renamed previousMap to executeMap and currentMap to renderMap: I know these are only names,
but the new ones are in the style of the JSF lifecylce's execute and render portion and thus
IMO a bit easier to understand
 - refactored token handling (also concerning the POST-REDIRECT-GET pattern, which had some
bugs)
 - refactored redirect handling
 - refactored FacesMessage handling
 - major cleanup on the overall code of FlashImpl (more private helper methods, more documentation,
type-safety)
 - and last but not least: lots of test cases which cover nearly every possible scenario

For a better understanding of how things should work in the FlashImpl, I created an image
which shows how the FlashScope works for Users and internally.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message