myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jakob Korherr (JIRA)" <...@myfaces.apache.org>
Subject [jira] Reopened: (MYFACES-2836) HtmlResponseWriterImpl does not check if a CDATA section is already opened when writing the content of a script
Date Fri, 23 Jul 2010 10:12:50 GMT

     [ https://issues.apache.org/jira/browse/MYFACES-2836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jakob Korherr reopened MYFACES-2836:
------------------------------------


sorry, again there are a lot of test failures:

Failed tests: 
  teststandardNestingTest(org.apache.myfaces.context.PartialResponseWriterImplTest)
  testIllegalNestingResolvementTest(org.apache.myfaces.context.PartialResponseWriterImplTest)
  testIllegalNestingResolvementTest2(org.apache.myfaces.context.PartialResponseWriterImplTest)
  testStandardUpdate(org.apache.myfaces.context.PartialResponseWriterImplTest)
  testStandardUpdateNestedCDATA(org.apache.myfaces.context.PartialResponseWriterImplTest)
  testComponentAuthorNestingFailureTest(org.apache.myfaces.context.PartialResponseWriterImplTest)
  testStandardInsertAfter(org.apache.myfaces.context.PartialResponseWriterImplTest)
  testStandardInsertBefore(org.apache.myfaces.context.PartialResponseWriterImplTest)

> HtmlResponseWriterImpl does not check if a CDATA section is already opened when writing
the content of a script
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-2836
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2836
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: JSR-252
>    Affects Versions: 2.0.1
>            Reporter: Bruno Aranda
>            Assignee: Bruno Aranda
>             Fix For: 2.0.2-SNAPSHOT
>
>         Attachments: MUFACES-2836.patch
>
>
> Hi,
> When the default response writer writes a script, it includes CDATA tags around the body.
If the script is being written inside another CDATA section for some reason (Primefaces does
this in its partial response), then invalid XML is created.
> I attach patch for the fix to be reviewed, before I commit something not quite right
again and we can discuss. Basically, a simple boolean is used to check if a CDATA is already
open or not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message