myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeanne Waldman (JIRA)" <...@myfaces.apache.org>
Subject [jira] Created: (TRINIDAD-1862) warn if a style selector ends in 'icon' to prevent this from happening
Date Fri, 23 Jul 2010 00:33:51 GMT
warn if a style selector ends in 'icon' to prevent this from happening
----------------------------------------------------------------------

                 Key: TRINIDAD-1862
                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1862
             Project: MyFaces Trinidad
          Issue Type: Improvement
          Components: Skinning
    Affects Versions:  2.0.0.2-core 
            Reporter: Jeanne Waldman
            Assignee: Jeanne Waldman


I found that some of our skinning keys end in "-icon" and "Icon:alias" when they should have
ended in "-icon-style" or "IconStyle:alias". The reason is the parser code looks at -icon
and says it is an Icon Object, and it creates an Icon Object. If the 'content' property is
not there, it also creates a StyleNode. StyleNodes get transformed and written to the generated
CSS file. Icon Objects do not.

What should have happened is that anything that ended with -icon was an Icon Object, and if
there was no 'content' we output a warning, but do not create a StyleNode. 

It's not too late to add a warning, but it is too late to not create a StyleNode.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message