myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jakob Korherr (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (MYFACES-2839) cleanup of UIInput
Date Mon, 26 Jul 2010 09:39:57 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-2839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892235#action_12892235
] 

Jakob Korherr commented on MYFACES-2839:
----------------------------------------

For _ExternalSpecifications there is already an issue in the JIRA: MYFACES-2582

> cleanup of UIInput
> ------------------
>
>                 Key: MYFACES-2839
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2839
>             Project: MyFaces Core
>          Issue Type: Improvement
>    Affects Versions: 2.0.1
>            Reporter: Matthias We├čendorf
>            Priority: Minor
>
> looking at shouldValidateEmptyFields() I see this code:
> ...
>        ExternalContext extCtx = context.getExternalContext();
>        String validateEmptyFields = (String)
> extCtx.getInitParameter(VALIDATE_EMPTY_FIELDS_PARAM_NAME);
>        if (validateEmptyFields == null)
>        {
>            validateEmptyFields = (String)
> extCtx.getApplicationMap().get(VALIDATE_EMPTY_FIELDS_PARAM_NAME);
>        }
> ....
> => Should be cached on application_map instead of always parsing the web.xml (getInitParam())-
> Actually I don't see a put to stored it on the applcaitonMap;
> Inside of the validate() I see similar code:
> String contextParam =
> context.getExternalContext().getInitParameter(EMPTY_VALUES_AS_NULL_PARAM_NAME);
> => not cached
> Similar in the _ExternalSpecifications clazz, no cache maintained here

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message