myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Leonardo Uribe (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (MYFACES-2779) PartialResponse bogus response on render all because of falsely positioned development stage script tag
Date Fri, 02 Jul 2010 20:25:49 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-2779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12884797#action_12884797
] 

Leonardo Uribe commented on MYFACES-2779:
-----------------------------------------

There is an typo error on PartialResponseImpl:

    @Override
    public void write(char[] cbuf, int off, int len) throws IOException {
        if (isDoubleBufferEnabled()) {
            _cdataDoubleBufferWriter.writeText(cbuf, off, len);
        } else {
            super.write(cbuf, off, len);
        }
    }

It should be

    @Override
    public void write(char[] cbuf, int off, int len) throws IOException {
        if (isDoubleBufferEnabled()) {
            _cdataDoubleBufferWriter.write(cbuf, off, len);
        } else {
            super.write(cbuf, off, len);
        }
    }

Instead call write we are calling writeText. The fix was committed.

> PartialResponse bogus response on render all because of falsely positioned development
stage script tag
> -------------------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-2779
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2779
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: JSR-314
>    Affects Versions: 2.0.2-SNAPSHOT
>            Reporter: Werner Punz
>
> Hello Everyone some changes in the latest codebase cause a bogus render all response:
> Here is the output I am getting:
> http://www.pastebin.org/368077
> as you can see the development stage is rendered before the html definition, any proper
html parsing on such an output has to fail.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message