myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Leonardo Uribe (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (MYFACES-2802) Remove CompositeComponentResourceTagHandler.ATTACHED_OBJECT_HADLERS_KEY from Attributes Map
Date Sat, 10 Jul 2010 23:00:50 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-2802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887107#action_12887107
] 

Leonardo Uribe commented on MYFACES-2802:
-----------------------------------------

The idea looks good, but the patch shows this map:

private static final Map<UIComponent, List<AttachedObjectHandler>> _attachedObjectHandlers
= new HashMap<UIComponent, List<AttachedObjectHandler>>();

Instead use a map on a static variable, it is better to put it as a key on FacesContext attribute
map, or even better, put it on org.apache.myfaces.view.facelets.FaceletCompositionContext
(the intention is provide a context for facelets build, so this is the right place to put
it). Note FaceletCompositionContext is already stored on FacesContext attribute map.

> Remove CompositeComponentResourceTagHandler.ATTACHED_OBJECT_HADLERS_KEY from Attributes
Map
> -------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-2802
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2802
>             Project: MyFaces Core
>          Issue Type: Improvement
>          Components: General
>    Affects Versions: 2.0.0
>            Reporter: Marius Petoi
>            Priority: Minor
>         Attachments: attachedObjectHandlers.patch
>
>
> Another state saving improvement is to remove the attached object handlers from the component
attributes map. Instead a map that holds the attached object handlers indexed by the component
reference will be created in CompositeComponentResourceTagHandler.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message