myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Freedman (JIRA)" <...@myfaces.apache.org>
Subject [jira] Resolved: (PORTLETBRIDGE-156) Encoding Public render parameters in a render redirect done incorrectly if url already action encoded
Date Thu, 29 Jul 2010 16:02:16 GMT

     [ https://issues.apache.org/jira/browse/PORTLETBRIDGE-156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Michael Freedman resolved PORTLETBRIDGE-156.
--------------------------------------------

    Fix Version/s: 2.0.0-beta
       Resolution: Fixed

PRP encoding no longer done by adding to end of QS, rather we attach as extra parameters in
the qs object we place on a request attribute that carries the render redirect info.

> Encoding Public render parameters in a render redirect done incorrectly if url already
action encoded
> -----------------------------------------------------------------------------------------------------
>
>                 Key: PORTLETBRIDGE-156
>                 URL: https://issues.apache.org/jira/browse/PORTLETBRIDGE-156
>             Project: MyFaces Portlet Bridge
>          Issue Type: Bug
>          Components: Impl
>    Affects Versions: 2.0.0-alpha
>            Reporter: Michael Freedman
>            Assignee: Michael Freedman
>             Fix For: 2.0.0-beta
>
>
> If you issue a render redirect on an url that you have already called encodeActionURL
on the bridge screws up big time because it merely encodes the extra public render parameters
to the end of the passed in url as part of a query string.  This (obviously) changes the url
so that it no longer matches when used as the key to lookup the request attribute to see if
this url is already action encoded.  Since we don't think its action encoded (but it is) we
go ahead an re-encode it turning the resulting redirect url into garbage.
> Fix is to delay adding the public render parameters to the url until after the check
to see if already action encoded.  When already encoded add the PRP to the querystring object
that is added to the request (attribute) otherwise add to the query string.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message