myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeanne Waldman (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (TRINIDAD-17) Need to support mapping icons via -tr-rule-ref like we do with styles.
Date Wed, 21 Jul 2010 03:10:49 GMT

    [ https://issues.apache.org/jira/browse/TRINIDAD-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890544#action_12890544
] 

Jeanne Waldman commented on TRINIDAD-17:
----------------------------------------

Blake is fine if we have the design time warn for us. He is ok if we pollute our CSS file.
It should be an uncommon usecase.

The most common use case for icons is:

base skin

af|foo-icon {width: 16px; height: 16px; border: 1px black solid; content: url("")}

skin A extends base skin

af|foo-icon {content:url("differentURL"); tr-rule-ref: selector("af|foo-icon");}

So it will have a content and we'll know it is an Icon and no StyleNode will be created.

---

In a few cases where someone messed up style selectors by naming them -icon:

.CBDialogHeadCloseIcon {
    -tr-rule-ref: selector(".CBDialogHeadCloseIcon:alias");
}

af|dialog::close-icon {
    -tr-rule-ref: selector(".CBDialogHeadCloseIcon");
}

.CBDialogHeadCloseIcon:alias {
    -tr-rule-ref: selector(".CBIconLook:alias");
    -tr-rule-ref: selector(".CBIconError:alias");
}

For af|dialog::close-icon, we know it doesn't have a 'content', but it does include a selector
that ends in 'icon'. We create both a StyleNode and an IconNode. It resolves fine when we
resolve it as a StyleNode. Still, log a warning about the name.

--

Uncommon usecase is where we do not override content for icons.

base skin

af|bar-icon {width: 16px; height: 16px; border: 1px black solid; content: url("")}

skin A extends base skin

af|foo-icon {border: 1px red solid; tr-rule-ref: selector("af|bar-icon");}

-- We create both an Icon and a StyleNode. When we resolve the selectors while thinking it
is a StyleNode, we will not find "af|bar-icon", because a StyleNode was never created.
--- we can warn the user and still write it to the CSS file. It won't have the 'content' attribute.
This should be a VERY UNCOMMON usecase




> Need to support mapping icons via -tr-rule-ref like we do with styles.
> ----------------------------------------------------------------------
>
>                 Key: TRINIDAD-17
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-17
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Skinning
>    Affects Versions: 1.2.1-core
>         Environment: Windows.
>            Reporter: Bill Baggett
>
> Trinidad skinning supports mapping styles in a css file via the -tr-rule-ref.  But, it
doesn't support mapping icons this way.  We need to support this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message