myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jakob Korherr (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (MYFACES-2730) FacesContext not available on application startup
Date Tue, 22 Jun 2010 12:24:01 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12881183#action_12881183
] 

Jakob Korherr commented on MYFACES-2730:
----------------------------------------

Hi Leo,

First of all I don't think it is such a bad idea to delete files if they are really not needed
anymore, because - in the worst case - you can use svn copy to get the file with history from
the branch. Also those two files were not changed since the last release.

Second: I object your theory "StartupFacesContextImpl must implement as many features as possible
to prevent exceptions". The spec says the behavior is not defined for those methods, thus
no application or framework is allowed to use them at startup or shutdown. If we allow this
with some dummy objects, some very weird things may occur and users will get confused. If
we throw an Exception instead, the user will know that he did something wrong. I mean, that's
the whole point of an Exception, isn't it?

Furthermore there was no redundancy in my solution, so your objection "the disavantage of
make maintain more difficult, because in future versions we should update it too" is wrong.
You see, I introduced a special base impl class to get rid of every redundancy and to make
maintaining this stuff very easy. But I guess you did not see it...

That's why I object committing any of your patches. However this issue is also a showstopper
for the 2.0.1 release (for me).

I am sorry if this is a bit rough, but frankly I am very annoyed, because I spent a lot of
time working on this and all you do is revert all my code and do your own solution without
asking me first. I know now that my solution was not complete (some more checks are needed
in different parts of the code - like MYFACES-2766), but your solution also does not solve
those problems and will, on my opinion, cause more weird problems than it solves.

> FacesContext not available on application startup
> -------------------------------------------------
>
>                 Key: MYFACES-2730
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2730
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: JSR-127, JSR-252, JSR-314
>    Affects Versions: 1.1.8, 1.2.9, 2.0.0
>            Reporter: Nick Belaevski
>            Assignee: Leonardo Uribe
>             Fix For: 2.0.2-SNAPSHOT
>
>         Attachments: MYFACES-2730-1.patch, MYFACES-2730-2.patch, MYFACES-2730-revert.patch
>
>
> If custom ResourceHandler calls FacesContext.getCurrentInstance() in constructor to read
init parameters, null value is returned. This affects latest MyFaces 2.0.0-SNAPSHOT. Mojarra
2.0 provides InitFacesContext in this case.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message