myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Leonardo Uribe (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (MYFACES-2697) BeanValidation class is annotated with @FacesValidator tag
Date Tue, 04 May 2010 22:24:03 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-2697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864050#action_12864050
] 

Leonardo Uribe commented on MYFACES-2697:
-----------------------------------------

I commented the previous solution and committed what I think it is the correct interpretation
of the spec. 

I think the config param just takes precedence over empty <default-validators/>. Why?
because do the opposite means in some conditions the param just will not work and it will
not be clear for the user. Also, the documentation of the param does not mention that side
effect:

"....If this param is defined, and calling toLowerCase().equals("true") on a String representation
of its value returns true, the runtime must not automatically add the validator with validator-id
equal to the value of the symbolic constant VALIDATOR_ID  to the list of default validators.
Setting this parameter to true will have the effect of disabling the automatic installation
of Bean Validation to every input component in every view in the application, though manual
installation is still possible....."

> BeanValidation class is annotated with @FacesValidator tag
> ----------------------------------------------------------
>
>                 Key: MYFACES-2697
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2697
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: JSR-314
>    Affects Versions: 2.0.0
>            Reporter: Leonardo Uribe
>            Assignee: Jakob Korherr
>             Fix For: 2.0.1-SNAPSHOT
>
>
> BeanValidation class is annotated with @FacesVallidator annotation, and it should not
be.
> We know that by default BeanValidation should be added to the Application object only
if the param javax.faces.validator.DISABLE_DEFAULT_BEAN_VALIDATOR is set to false. So, there
is no reason to use @FacesValidator, let the scanner find it and then check the property.
It is better keep things simple and simplify the code on FacesConfigurator.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message