myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jakob Korherr (JIRA)" <...@myfaces.apache.org>
Subject [jira] Created: (MYFACES-2690) Do not create the view for a debug request
Date Sat, 01 May 2010 10:27:53 GMT
Do not create the view for a debug request
------------------------------------------

                 Key: MYFACES-2690
                 URL: https://issues.apache.org/jira/browse/MYFACES-2690
             Project: MyFaces Core
          Issue Type: Improvement
          Components: JSR-314
    Affects Versions: 2.0.0
            Reporter: Jakob Korherr
            Assignee: Jakob Korherr


When using <ui:debug> on a facelet page the user can get debug info with ctrl+shift+d.
This debug info is created by UIDebug.debugRequest() in FaceletVDL.createView().

UIDebug.debugRequest() calls FacesContext.responseComplete() if the request was a debug request
and the information was written to the response writer. However we currently do not check
that right after the call to UIDebug.debugRequest() and thus we continue with the whole RestoreView
phase before we stop processing in LifecycleImpl (where FacesContext.getResponseComplete()
is checked).

If we check response complete right after the call to UIDebug.debugRequest(), we can skip
any further processing and thus be a lot faster here. The only thing we have to care about
is that FaceletVDL.createView() will return null and thus we need some null checks (but this
should happen anyway, I guess).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message