Return-Path: Delivered-To: apmail-myfaces-dev-archive@www.apache.org Received: (qmail 67693 invoked from network); 26 Apr 2010 16:45:31 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 26 Apr 2010 16:45:31 -0000 Received: (qmail 28207 invoked by uid 500); 26 Apr 2010 16:45:30 -0000 Delivered-To: apmail-myfaces-dev-archive@myfaces.apache.org Received: (qmail 28166 invoked by uid 500); 26 Apr 2010 16:45:30 -0000 Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "MyFaces Development" Delivered-To: mailing list dev@myfaces.apache.org Received: (qmail 28159 invoked by uid 99); 26 Apr 2010 16:45:30 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Apr 2010 16:45:30 +0000 X-ASF-Spam-Status: No, hits=2.2 required=10.0 tests=FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of sethfromaustria@gmail.com designates 74.125.78.149 as permitted sender) Received: from [74.125.78.149] (HELO ey-out-1920.google.com) (74.125.78.149) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Apr 2010 16:45:24 +0000 Received: by ey-out-1920.google.com with SMTP id 5so164534eyb.16 for ; Mon, 26 Apr 2010 09:45:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:content-type; bh=e9CJJKjiO3YlWT+YMI12dSYMwm60tQODB+1bM06agEE=; b=OGPOhHEpckGt4oOiQz8zt6W1gpOb0fmfR36widOCXS9uW1saBmhbLEewkWcUWpz1ze Mx/dJozN3sGcGQoXy04Qch4YrNzTV9dQIgHeNciHwg17eOQ1nn0u7BaRnxB0mgMsUYtQ gcI7mJ8GEwl8to7L/GHlJInmFfk5wbhsmuMW4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type; b=EqzM3WgnHVgz/OpG9WmhndYUcuW5N0+tB6Gu2vsBMEPOGI8Qy9e7nr9IwYMPyt4NPm ukinNfRgi6hCwYbK9HNj3ZX/LgXI96CIypmDGRNRsU1Zm3iAblDZ/zx00D8YgdvZ6jGy AopaHAZaJtZGfwamjheEg3TMV315gRKqc8Mng= MIME-Version: 1.0 Received: by 10.102.214.32 with SMTP id m32mr2505518mug.42.1272300304271; Mon, 26 Apr 2010 09:45:04 -0700 (PDT) Sender: sethfromaustria@gmail.com Received: by 10.103.228.12 with HTTP; Mon, 26 Apr 2010 09:45:04 -0700 (PDT) In-Reply-To: References: <20100423181551.145D523889B6@eris.apache.org> Date: Mon, 26 Apr 2010 18:45:04 +0200 X-Google-Sender-Auth: 5395359773b5a21a Message-ID: Subject: Re: svn commit: r937451 - /myfaces/core/trunk/impl/pom.xml From: Jakob Korherr To: MyFaces Development Content-Type: multipart/alternative; boundary=001636426975af0a3e0485267f90 X-Virus-Checked: Checked by ClamAV on apache.org --001636426975af0a3e0485267f90 Content-Type: text/plain; charset=UTF-8 Hi Leo, Yes I just realized that, because my IDE told me that there are compilation errors on myfaces-impl. So I was a bit to fast in just reverting your commit, sorry! However we have to find a solution that does not include the sources in the IDE, but in the sources.jar. When I first implemented the merging of implee6 and impl I moved the addition of the implee6-sources to a later phase in maven to circumvent this problem, but I think this causes problems in the release. Do you remember exactly why this was wrong? Regards, Jakob 2010/4/26 Leonardo Uribe > Hi Jakob > > The problem with let implee6 is that when I execute the goal mvn > eclipse:eclipse, it is included on the source path, but since the files on > ee6 are compiled by a different environment, it shows like there is an > error. > > regards, > > Leonardo Uribe > > 2010/4/26 Jakob Korherr > > Hi Leonardo, >> >> Actually it is necessary to add the sources, otherwise >> myfaces-impl-2.0.1-SNAPSHOT-sources.jar would not contain the source files >> from implee6, which it definitely has to! >> >> Thus I will revert this commit. >> >> Regards, >> Jakob >> >> 2010/4/23 >> >>> Author: lu4242 >>> Date: Fri Apr 23 18:15:50 2010 >>> New Revision: 937451 >>> >>> URL: http://svn.apache.org/viewvc?rev=937451&view=rev >>> Log: >>> add as source dir implee6 is not necessary (added .java as resource >>> instead) >>> >>> Modified: >>> myfaces/core/trunk/impl/pom.xml >>> >>> Modified: myfaces/core/trunk/impl/pom.xml >>> URL: >>> http://svn.apache.org/viewvc/myfaces/core/trunk/impl/pom.xml?rev=937451&r1=937450&r2=937451&view=diff >>> >>> ============================================================================== >>> --- myfaces/core/trunk/impl/pom.xml (original) >>> +++ myfaces/core/trunk/impl/pom.xml Fri Apr 23 18:15:50 2010 >>> @@ -506,7 +506,9 @@ >>> >>> >>> >>> ${project.build.directory}/shared_sources >>> + >>> >>> >>> >>> >>> >>> >> >> >> -- >> Jakob Korherr >> >> blog: http://www.jakobk.com >> twitter: http://twitter.com/jakobkorherr >> work: http://www.irian.at >> > > -- Jakob Korherr blog: http://www.jakobk.com twitter: http://twitter.com/jakobkorherr work: http://www.irian.at --001636426975af0a3e0485267f90 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Leo,

Yes I just realized that, because my IDE told me that there = are compilation errors on myfaces-impl. So I was a bit to fast in just reve= rting your commit, sorry!

However we have to find a solution that do= es not include the sources in the IDE, but in the sources.jar.

When I first implemented the merging of implee6 and impl I moved the ad= dition of the implee6-sources to a later phase in maven to circumvent this = problem, but I think this causes problems in the release. Do you remember e= xactly why this was wrong?

Regards,
Jakob

2010/4/26 Leonardo = Uribe <lu4242@gmai= l.com>
Hi Jakob

The problem with let implee6 is that when I execute the goa= l mvn eclipse:eclipse, it is included on the source path, but since the fil= es on ee6 are compiled by a different environment, it shows like there is a= n error.

regards,

Leonardo Uribe

2010/4= /26 Jakob Korherr <jakob.korherr@gmail.com>
<= /div>

Hi Leonardo,

Actually it is necessary to add the sources, otherwise = myfaces-impl-2.0.1-SNAPSHOT-sources.jar would not contain the source files = from implee6, which it definitely has to!

Thus I will revert this co= mmit.

Regards,
Jakob

2010/4/23 <lu4242= @apache.org>
Author: lu4242
Date: Fri Apr 23 18:15:50 2010
New Revision: 937451

URL: http://svn.apache.org/viewvc?rev=3D937451&view=3Drev
Log:
add as source dir implee6 is not necessary (added .java as resource instead= )

Modified:
=C2=A0 =C2=A0myfaces/core/trunk/impl/pom.xml

Modified: myfaces/core/trunk/impl/pom.xml
URL: http://svn.apache.org/viewvc/myfaces/core/trunk/impl/pom.xml?rev=3D9= 37451&r1=3D937450&r2=3D937451&view=3Ddiff
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D
--- myfaces/core/trunk/impl/pom.xml (original)
+++ myfaces/core/trunk/impl/pom.xml Fri Apr 23 18:15:50 2010
@@ -506,7 +506,9 @@
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 <= configuration>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 <sources>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 <source>${project.build.directory}/shared_sources</sour= ce>
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0<!--
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 <source>${project.build.directory}/implee6_sources</sou= rce>
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 -->
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 </sources>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 <= /configuration>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 </execut= ion>





--
Jakob Korherr

bl= og: http://www.jakobk.c= om
twitter: http://twitter.com/jakobkorherr
work: http://www.irian.at=




--
Jakob Korherr

bl= og: http://www.jakobk.com
twitter:= http://twitter.com/jakobkorher= r
work: http://www.irian.at
--001636426975af0a3e0485267f90--