Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "MyFaces Development" <dev@myfaces.apache.org>
Message-ID: <27052335.1431272527875167.JavaMail.jira@thor>
Date: Thu, 29 Apr 2010 03:57:55 -0400 (EDT)
From: "Michael Heinen (JIRA)" <dev@myfaces.apache.org>
To: dev@myfaces.apache.org
Subject: [jira] Commented: (TOMAHAWK-1494) HtmlMessageRenderer evaluates
 value expressions of not rendered components
In-Reply-To: <1579484990.553731267188868029.JavaMail.jira@brutus.apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/TOMAHAWK-1494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862123#action_12862123 ] 

Michael Heinen commented on TOMAHAWK-1494:
------------------------------------------

Leonardo, this sounds even better to me. Perfect.
Moreover this should also improve performance a little bit in cases of many outputLabels because the ValueExpressions are not evaluated if not needed.

Thumbs up ;-)

> HtmlMessageRenderer evaluates value expressions of not rendered components
> --------------------------------------------------------------------------
>
>                 Key: TOMAHAWK-1494
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1494
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Message(s)
>    Affects Versions: 1.1.9
>         Environment: tomahawk12_1.1.9, 
> myfaces 1.2.8,
> richfaces 3.3.3
> jsp
>            Reporter: Michael Heinen
>            Assignee: Leonardo Uribe
>            Priority: Critical
>
> I produced a validation error in an inputText field. This field ha a corresponding outputLabel component.
> Now HtmlMessageRenderer creates a Map with all inputLabels, even if they are not rendered at all.
> This can result in exceptions because the value attribute of not rendered and not initialized components is evaluated!
> Sample content:
> <t:div rendered="false">
>   <t:outputLabel id="abcabcLbl"  for="abcabc" value="#{MyController.testme} "/>
>   <t:inputText id="abcabc" value="#{requestScope['test222']}"/>
> </t:div>
> Method MyController.getTestme() is called if messages are rendered although the parent div component has attribute rendered=false
> proposed fix:
>   if (root.isRendered()) 
> should be added to method createOutputLabelMap.
> Components should not be checked recursively if the root is not rendered at all.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.