myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Leonardo Uribe (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (MYFACES-2546) Conversion rules for obtaing renderable String from the "value" property of SelectItem
Date Tue, 06 Apr 2010 19:51:34 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-2546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854142#action_12854142
] 

Leonardo Uribe commented on MYFACES-2546:
-----------------------------------------

The patch is correct. The interpretation of the javadoc is that is necessary first to convert
the value property using the conversion rules, that means, get a converter for the value if
available and othewise try to use the default converter. We are doing this step when we call
RendererUtils.findUISelectManyConverter, HtmlRendererUtils.findUIOutputConverterFailSafe,
RendererUtils.findUIOutputConverter.

Really we are doing what spec says, but if ri is calling toString() as last effort, we should
do the same too.

> Conversion rules for obtaing renderable String from the "value" property of SelectItem
> --------------------------------------------------------------------------------------
>
>                 Key: MYFACES-2546
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2546
>             Project: MyFaces Core
>          Issue Type: Improvement
>          Components: JSR-314
>    Affects Versions: 2.0.0-beta-2
>         Environment: myfaces trunk
>            Reporter: Martin Koci
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: MYFACES-2546.patch
>
>
> <h:selectOneMenu>
>         <f:selectItems value="#{model.selectItemsWithNonStringValue}" />
> </h:selectOneMenu>
> if SelectItem.getValue() returns other type than String and there is no converter for
that type, myfaces throw exception: java.lang.IllegalArgumentException: Value is no String
> at org.apache.myfaces.shared_impl.renderkit.RendererUtils.getConvertedStringValue(RendererUtils.java:633)
> 	at org.apache.myfaces.shared_impl.renderkit.RendererUtils.getConvertedStringValue(RendererUtils.java:652)
> 	at org.apache.myfaces.shared_impl.renderkit.html.HtmlRendererUtils.renderSelectOptions(HtmlRendererUtils.java:538)
> RI does not throw a exception but with quietness outputs toString() as <option>
value.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message