myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Leonardo Uribe (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (TOMAHAWK-1500) t:inputHtml should be a composite component for jsf 2.0
Date Tue, 27 Apr 2010 21:16:32 GMT

    [ https://issues.apache.org/jira/browse/TOMAHAWK-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861545#action_12861545
] 

Leonardo Uribe commented on TOMAHAWK-1500:
------------------------------------------

I have attached a patch for this one (I worked on this one some days ago). With this patch,
InputHtml will be NamingContainer. Obviously, this patch makes t:inputHtml only works for
facelets on jsf 2.0, but that is not a problem, because the decision is tomahawk for jsf 2.0
will support facelets only (new features in jsf 2.0 are only available in that mode). Note
that tomahawk usage of new Resource api impose that restriction from start.

If no objections I'll commit this patch soon. I hope with this fix it will be easier to add
new features for this component. 

> t:inputHtml should be a composite component for jsf 2.0
> -------------------------------------------------------
>
>                 Key: TOMAHAWK-1500
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1500
>             Project: MyFaces Tomahawk
>          Issue Type: Improvement
>          Components: Html Editor
>    Affects Versions: 1.1.9
>            Reporter: Leonardo Uribe
>            Assignee: Leonardo Uribe
>         Attachments: TOMAHAWK-1500.patch
>
>
> t:inputHtml is the best example why composite components are a great idea. We have an
unmaintanable renderer that just render html markup and more html markup. It was very difficult
to upgrade to kupu 1.4.16 (in fact I used some hacks to do the opposite: convert from html
markup to ResponseWriter commands and then update the renderer). 
> Minor changes are needed to make it a composite component and no side effects are detected
in the change.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message