myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Heinen (JIRA)" <>
Subject [jira] Commented: (TOMAHAWK-1494) HtmlMessageRenderer evaluates value expressions of not rendered components
Date Thu, 29 Apr 2010 07:57:55 GMT


Michael Heinen commented on TOMAHAWK-1494:

Leonardo, this sounds even better to me. Perfect.
Moreover this should also improve performance a little bit in cases of many outputLabels because
the ValueExpressions are not evaluated if not needed.

Thumbs up ;-)

> HtmlMessageRenderer evaluates value expressions of not rendered components
> --------------------------------------------------------------------------
>                 Key: TOMAHAWK-1494
>                 URL:
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Message(s)
>    Affects Versions: 1.1.9
>         Environment: tomahawk12_1.1.9, 
> myfaces 1.2.8,
> richfaces 3.3.3
> jsp
>            Reporter: Michael Heinen
>            Assignee: Leonardo Uribe
>            Priority: Critical
> I produced a validation error in an inputText field. This field ha a corresponding outputLabel
> Now HtmlMessageRenderer creates a Map with all inputLabels, even if they are not rendered
at all.
> This can result in exceptions because the value attribute of not rendered and not initialized
components is evaluated!
> Sample content:
> <t:div rendered="false">
>   <t:outputLabel id="abcabcLbl"  for="abcabc" value="#{MyController.testme} "/>
>   <t:inputText id="abcabc" value="#{requestScope['test222']}"/>
> </t:div>
> Method MyController.getTestme() is called if messages are rendered although the parent
div component has attribute rendered=false
> proposed fix:
>   if (root.isRendered()) 
> should be added to method createOutputLabelMap.
> Components should not be checked recursively if the root is not rendered at all.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message