Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "MyFaces Development" <dev@myfaces.apache.org>
Received-SPF: pass (nike.apache.org: domain of mwessendorf@gmail.com
 designates 209.85.219.218 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:sender:in-reply-to:references:date
         :x-google-sender-auth:message-id:subject:from:to:content-type
         :content-transfer-encoding;
        b=YiAW/z4SssSeZFhrPwaKB0o3W+xvEf2fqLHeN3zxfLR3cZduF8QXUFoUqCO38enbEA
         5PaWXHzZ8lpImi5DxVj/TYcm/82a1qkCgIW8acDM6ODDD5Zfd1MGrxHenhaRDR8v+csX
         VlP58O1wvua9aYOPY2EvXnHlvhhWp7xd4fw7Y=
MIME-Version: 1.0
Sender: mwessendorf@gmail.com
In-Reply-To: <4B8D2B5D.5000302@oracle.com>
References: <4B8C2A63.6040802@oracle.com> <4B8C55F1.5080905@oracle.com>
	 <3491C499-CA6E-40A0-B6F2-312E32E71C15@oracle.com>
	 <71235db41003012219p5baf088q9ea535e9f700715@mail.gmail.com>
	 <4B8D2B5D.5000302@oracle.com>
Date: Tue, 2 Mar 2010 16:16:37 +0100
Message-ID: <71235db41003020716q6ed21151kab242d85d445b64c@mail.gmail.com>
Subject: Re: [Trinidad2] InternalView VDL/TRINIDAD-1735
From: Matthias Wessendorf <matzew@apache.org>
To: MyFaces Development <dev@myfaces.apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

that would qualify the patch as -1

On Tue, Mar 2, 2010 at 4:14 PM, Max Starets <max.starets@oracle.com> wrote:
> Matthias,
>
> And one more thing - no Sun RI code was copied.
>
> Max
>
> Matthias Wessendorf wrote:
>
> -1 on the patch.
>
> We really can't use license header from LGPL2code...:
> -InternalViewHandlingStrategy
> -ViewDeclarationLanguageFactoryImpl
>
> Nor can't we copy code from the SUN RI to Apache.
>
> -Matthias
>
>
> On Tue, Mar 2, 2010 at 1:40 AM, Max Starets <max.starets@oracle.com> wrot=
e:
>
>
> Gary,
> No, this just sn internal reorganization, and there will be no API change=
s.
> Max
>
> On Mar 1, 2010, at 7:04 PM, Gary Kind <gary.kind@oracle.com> wrote:
>
> Will this affect the Controller team?
>
> Gary Kind
>
> Max Starets wrote:
>
> Hello Everyone,
>
> While I was working on a solution for TRINIDAD-1735, I realized that the
> clean solution
> would involve moving all the code dealing with InternalViews from the
> ViewHandlerImpl to
> the new ViewDeclarationLanguageFactoryImpl.=A0 We also would expose a spe=
cial
> VDL for the internal
> views, which is what Martin Koci suggested a while ago.
>
> Pleas review the jira and the associated patch. If there are no objection=
s,
> I will commit the change in
> a few days.
>
> Thanks,
> Max
>
>
>
>
>
>


--=20
Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf